From commits-return-7517-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Tue May 1 23:07:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDC89180645 for ; Tue, 1 May 2018 23:07:02 +0200 (CEST) Received: (qmail 18111 invoked by uid 500); 1 May 2018 21:07:00 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 18102 invoked by uid 99); 1 May 2018 21:07:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 21:07:00 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jai1 commented on a change in pull request #1702: Allow to configure TLS hostname verification in PulsarAdmin Message-ID: <152520881991.24755.13654388270541311871.gitbox@gitbox.apache.org> Date: Tue, 01 May 2018 21:06:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jai1 commented on a change in pull request #1702: Allow to configure TLS hostname verification in PulsarAdmin URL: https://github.com/apache/incubator-pulsar/pull/1702#discussion_r185334395 ########## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java ########## @@ -46,6 +46,13 @@ @Parameter(names = { "--auth-params" }, description = "Authentication parameters, e.g., \"key1:val1,key2:val2\".") String authParams = null; + @Parameter(names = { "--tls-allow-insecure" }, description = "Allow TLS insecure connection") + Boolean tlsAllowInsecureConnection; + + + @Parameter(names = { "--tls-enable-hostname-verification" }, description = "Enalbe TLS common name verification") Review comment: Typo in enable ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services