pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected
Date Tue, 22 May 2018 05:31:51 GMT
merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is
disconnected
URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r189780844
 
 

 ##########
 File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
 ##########
 @@ -140,6 +140,10 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception
{
             directProxyHandler.outboundChannel.close();
         }
 
+        if (client != null) {
+            client.close();
+        }
 
 Review comment:
   I don't understand why we want to close the entire client at this point. 
   
   When this connection gets closed, we want its paired connection to be closed as well. This
should already done at line 140 here above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message