pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #1708: Refactor functions to use Sink interface
Date Wed, 02 May 2018 07:20:38 GMT
sijie commented on a change in pull request #1708: Refactor functions to use Sink interface
URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185410631
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/RuntimeSink.java
 ##########
 @@ -29,7 +32,9 @@
  * <p>There is a default implementation provided for wrapping up the user provided
{@link Sink}. Pulsar sink
  * should be implemented using this interface to ensure supporting effective-once.
  */
-public interface RuntimeSink<T> extends Sink<T> {
+//public interface RuntimeSink<T> extends Sink<T> {
 
 Review comment:
   the changes here are not needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message