pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #1708: Refactor functions to use Sink interface
Date Wed, 02 May 2018 07:20:37 GMT
sijie commented on a change in pull request #1708: Refactor functions to use Sink interface
URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185409710
 
 

 ##########
 File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java
 ##########
 @@ -45,5 +45,5 @@
      * @param value output value
      * @return Completable future fo async publish request
      */
-    CompletableFuture<Void> write(T value);
-}
\ No newline at end of file
+    CompletableFuture<Void> write(T value) throws Exception;
 
 Review comment:
   Exception should be thrown through `CompletableFuture<Void>`, no?
   
   It is a bit strange to throw exception for a method that returns `CompletableFuture`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message