pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #1700: adding sink spec
Date Tue, 01 May 2018 03:25:14 GMT
srkukarni commented on a change in pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#discussion_r185160964
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -43,15 +43,16 @@ message FunctionDetails {
     string namespace = 2;
     string name = 3;
     string className = 4;
-    string outputSerdeClassName = 5;
-    string output = 6;
+//    string outputSerdeClassName = 5;
 
 Review comment:
   pl remove instead of commenting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message