Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pulsar.incubator.apache.org
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] sijie commented on a change in pull request #961: Issue 922: allow run bookie together with broker
Message-ID: <151311192244.668.4399890172571157750.gitbox@gitbox.apache.org>
archived-at: Tue, 12 Dec 2017 20:52:04 -0000

sijie commented on a change in pull request #961: Issue 922: allow run bookie together with broker
URL: https://github.com/apache/incubator-pulsar/pull/961#discussion_r156476944
 
 
 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
 ##########
 @@ -44,8 +55,79 @@ private static ServiceConfiguration loadConfig(String configFile) throws Excepti
         return config;
     }
 
+    private static final Options OPTS = new Options();
+    static {
+        OPTS.addOption("b", "bookie", false, "Run Bookie Server together");
 
 Review comment:
   It seems the options don't match with `printUsage`. Can you make them consistent?
   
   `--run-bookie`, `--run-bookie-autorecovery`, `--bookie-conf`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services