pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #1006: Acknowledgement with properties for RawReader
Date Thu, 01 Jan 1970 00:00:00 GMT
sijie commented on a change in pull request #1006: Acknowledgement with properties for RawReader
URL: https://github.com/apache/incubator-pulsar/pull/1006#discussion_r158538953
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/client/api/RawReader.java
 ##########
 @@ -30,9 +31,10 @@
     /**
      * Create a raw reader for a topic.
      */
-    public static CompletableFuture<RawReader> create(PulsarClient client, String topic)
{
+    public static CompletableFuture<RawReader> create(PulsarClient client, String subscription,
 
 Review comment:
   topic, subscription is a better sequence than subscription, topic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message