pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mgodave commented on issue #933: PIP-9: Topic Compaction
Date Thu, 01 Jan 1970 00:00:00 GMT
mgodave commented on issue #933: PIP-9: Topic Compaction
URL: https://github.com/apache/incubator-pulsar/issues/933#issuecomment-350900886
 
 
   Looks good.
   
   Regarding your open question:
   
   > Should the compactor have a subscription so that it can cause messages to be retained
until compaction occurs.
   
   If I'm reading this correctly, you will need to make sure the topic is still around so
you will indeed require a cursor. On the first pass through you can read without acknowledgement
and save acknowledgement until the second pass. This would also prevent a compact job that
crashes anytime between the start and finish from missing data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message