pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lovelle commented on a change in pull request #942: Bugfix: duplicate messages for PartitionedConsumers.
Date Thu, 01 Jan 1970 00:00:00 GMT
lovelle commented on a change in pull request #942: Bugfix: duplicate messages for PartitionedConsumers.
URL: https://github.com/apache/incubator-pulsar/pull/942#discussion_r155335083
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedConsumerImpl.java
 ##########
 @@ -355,6 +385,8 @@ void messageReceived(Message message) {
             if (log.isDebugEnabled()) {
                 log.debug("[{}][{}] Received message from partitioned-consumer {}", topic,
subscription, message.getMessageId());
             }
+
+            unAckedMessageTracker.add((MessageIdImpl) message.getMessageId());
 
 Review comment:
   Im not sure about this, I think that tracker should add messages only if `!pendingReceives.isEmpty()`.
It is ok to track messages on a consumer which is not on receive call? Besides will result
in much less work by UnAckedMessageTracker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message