pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on issue #930: Issue #929: Perform async DNS resolution each time attempting connect?
Date Thu, 01 Jan 1970 00:00:00 GMT
rdhabalia commented on issue #930: Issue #929: Perform async DNS resolution each time attempting
connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#issuecomment-349506872
 
 
   > I'm not sure yet how to properly unit test this change, suggestions welcome.
   
   It would be better if we can add at least test case.? Does it make sense to create unit
test for `ConnectionPool` where we can mock `resolveName(..)` method which returns `List<InetAddress>`
with one dead/invalid dns-server and one correct (localhost). and unit-test should be able
to create connection with correct one.??

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message