Return-Path: X-Original-To: apmail-zest-commits-archive@minotaur.apache.org Delivered-To: apmail-zest-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E24F41826F for ; Thu, 17 Dec 2015 13:16:19 +0000 (UTC) Received: (qmail 21030 invoked by uid 500); 17 Dec 2015 13:16:19 -0000 Delivered-To: apmail-zest-commits-archive@zest.apache.org Received: (qmail 20980 invoked by uid 500); 17 Dec 2015 13:16:19 -0000 Mailing-List: contact commits-help@zest.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zest.apache.org Delivered-To: mailing list commits@zest.apache.org Received: (qmail 20696 invoked by uid 99); 17 Dec 2015 13:16:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2015 13:16:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 621ADE114B; Thu, 17 Dec 2015 13:16:18 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: niclas@apache.org To: commits@zest.apache.org Date: Thu, 17 Dec 2015 13:16:28 -0000 Message-Id: <72427cb6bc8b490584731eab275c0949@git.apache.org> In-Reply-To: <2bbb54267a634474a398b5bf10554eac@git.apache.org> References: <2bbb54267a634474a398b5bf10554eac@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [12/12] zest-java git commit: ZEST-136 - Fixed up some smaller issues. Still have the ServiceReference and ImportedService story messed up. ServiceQualifiers are not handled correctly. ZEST-136 - Fixed up some smaller issues. Still have the ServiceReference and ImportedService story messed up. ServiceQualifiers are not handled correctly. Project: http://git-wip-us.apache.org/repos/asf/zest-java/repo Commit: http://git-wip-us.apache.org/repos/asf/zest-java/commit/72314b85 Tree: http://git-wip-us.apache.org/repos/asf/zest-java/tree/72314b85 Diff: http://git-wip-us.apache.org/repos/asf/zest-java/diff/72314b85 Branch: refs/heads/ZEST-105 Commit: 72314b856f6360a899f48e56a2bf3ae2cc019e74 Parents: dedb068 Author: Niclas Hedhman Authored: Thu Dec 17 21:15:41 2015 +0800 Committer: Niclas Hedhman Committed: Thu Dec 17 21:15:41 2015 +0800 ---------------------------------------------------------------------- .../zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java | 6 ++++-- .../org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java | 2 +- .../org/apache/zest/runtime/service/ImportedServiceModel.java | 7 +++++-- .../java/org/apache/zest/runtime/value/ValueInstance.java | 2 +- .../zest/spi/service/importer/InstanceImporterTest.java | 2 -- 5 files changed, 11 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zest-java/blob/72314b85/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java ---------------------------------------------------------------------- diff --git a/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java b/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java index e7dd04f..44ee396 100644 --- a/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java +++ b/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ImportedServiceAssemblyImpl.java @@ -24,6 +24,7 @@ import org.apache.zest.api.common.MetaInfo; import org.apache.zest.api.common.Visibility; import org.apache.zest.api.service.ServiceImporter; import org.apache.zest.api.service.importer.InstanceImporter; +import org.apache.zest.api.structure.ModuleDescriptor; import org.apache.zest.bootstrap.ImportedServiceAssembly; import org.apache.zest.runtime.activation.ActivatorsModel; import org.apache.zest.runtime.service.ImportedServiceModel; @@ -59,7 +60,7 @@ public final class ImportedServiceAssemblyImpl } @SuppressWarnings( { "raw", "unchecked" } ) - void addImportedServiceModel( List serviceModels ) + void addImportedServiceModel( ModuleDescriptor module, List serviceModels ) { try { @@ -69,7 +70,8 @@ public final class ImportedServiceAssemblyImpl id = generateId( serviceModels, serviceType ); } - ImportedServiceModel serviceModel = new ImportedServiceModel( serviceType, + ImportedServiceModel serviceModel = new ImportedServiceModel( module, + serviceType, visibility, serviceProvider, id, http://git-wip-us.apache.org/repos/asf/zest-java/blob/72314b85/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java ---------------------------------------------------------------------- diff --git a/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java b/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java index e997460..6e2a356 100755 --- a/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java +++ b/core/runtime/src/main/java/org/apache/zest/runtime/bootstrap/ModuleAssemblyImpl.java @@ -568,7 +568,7 @@ public final class ModuleAssemblyImpl for( ImportedServiceAssemblyImpl importedServiceDeclaration : importedServiceAssemblies.values() ) { - importedServiceDeclaration.addImportedServiceModel( importedServiceModels ); + importedServiceDeclaration.addImportedServiceModel( moduleModel, importedServiceModels ); } // Check for duplicate service identities http://git-wip-us.apache.org/repos/asf/zest-java/blob/72314b85/core/runtime/src/main/java/org/apache/zest/runtime/service/ImportedServiceModel.java ---------------------------------------------------------------------- diff --git a/core/runtime/src/main/java/org/apache/zest/runtime/service/ImportedServiceModel.java b/core/runtime/src/main/java/org/apache/zest/runtime/service/ImportedServiceModel.java index f3bf992..8ca2dff 100644 --- a/core/runtime/src/main/java/org/apache/zest/runtime/service/ImportedServiceModel.java +++ b/core/runtime/src/main/java/org/apache/zest/runtime/service/ImportedServiceModel.java @@ -39,6 +39,7 @@ import org.apache.zest.runtime.activation.ActivatorsModel; public final class ImportedServiceModel implements ImportedServiceDescriptor, VisitableHierarchy { + private final ModuleDescriptor module; private final Class type; private final Visibility visibility; @SuppressWarnings( "raw" ) @@ -50,7 +51,8 @@ public final class ImportedServiceModel private final String moduleName; @SuppressWarnings( "raw" ) - public ImportedServiceModel( Class serviceType, + public ImportedServiceModel( ModuleDescriptor module, + Class serviceType, Visibility visibility, Class serviceImporter, String identity, @@ -60,6 +62,7 @@ public final class ImportedServiceModel String moduleName ) { + this.module = module; type = serviceType; this.visibility = visibility; this.serviceImporter = serviceImporter; @@ -91,7 +94,7 @@ public final class ImportedServiceModel @Override public ModuleDescriptor module() { - return null; + return module; } @Override http://git-wip-us.apache.org/repos/asf/zest-java/blob/72314b85/core/runtime/src/main/java/org/apache/zest/runtime/value/ValueInstance.java ---------------------------------------------------------------------- diff --git a/core/runtime/src/main/java/org/apache/zest/runtime/value/ValueInstance.java b/core/runtime/src/main/java/org/apache/zest/runtime/value/ValueInstance.java index beb232c..184c05b 100644 --- a/core/runtime/src/main/java/org/apache/zest/runtime/value/ValueInstance.java +++ b/core/runtime/src/main/java/org/apache/zest/runtime/value/ValueInstance.java @@ -168,6 +168,6 @@ public final class ValueInstance @Override public String toString() { - return ( (ModuleSpi) module() ).valueSerialization().serialize( this.proxy() ); + return ( (ModuleSpi) module().instance() ).valueSerialization().serialize( this.proxy() ); } } http://git-wip-us.apache.org/repos/asf/zest-java/blob/72314b85/core/runtime/src/test/java/org/apache/zest/spi/service/importer/InstanceImporterTest.java ---------------------------------------------------------------------- diff --git a/core/runtime/src/test/java/org/apache/zest/spi/service/importer/InstanceImporterTest.java b/core/runtime/src/test/java/org/apache/zest/spi/service/importer/InstanceImporterTest.java index 045e89e..bca35ee 100644 --- a/core/runtime/src/test/java/org/apache/zest/spi/service/importer/InstanceImporterTest.java +++ b/core/runtime/src/test/java/org/apache/zest/spi/service/importer/InstanceImporterTest.java @@ -46,8 +46,6 @@ public class InstanceImporterTest @Test public void givenSingletonServiceObjectWhenServicesAreInjectedThenSingletonIsFound() { - module.instance().injectTo( this ); - assertThat( "service is injected properly", service.helloWorld(), equalTo( "Hello World" ) ); }