From commits-return-16584-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Fri Feb 28 08:02:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99E88180636 for ; Fri, 28 Feb 2020 09:02:09 +0100 (CET) Received: (qmail 34258 invoked by uid 500); 28 Feb 2020 08:02:09 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 34249 invoked by uid 99); 28 Feb 2020 08:02:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2020 08:02:08 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments Message-ID: <158287692890.4264.4598780020056261901.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 28 Feb 2020 08:02:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r385554338 ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/ColumnProviderFactory.java ########## @@ -20,18 +20,29 @@ import org.apache.pinot.common.utils.CommonConstants.Segment.BuiltInVirtualColumn; import org.apache.pinot.common.utils.NetUtil; +import org.apache.pinot.core.segment.index.column.ColumnContext; +import org.apache.pinot.core.segment.index.column.ColumnProvider; +import org.apache.pinot.core.segment.index.column.DefaultNullValueColumnProvider; import org.apache.pinot.spi.data.DimensionFieldSpec; import org.apache.pinot.spi.data.FieldSpec; import org.apache.pinot.spi.data.Schema; /** - * Factory for virtual column providers. + * Factory for column providers. */ -public class VirtualColumnProviderFactory { - public static VirtualColumnProvider buildProvider(String virtualColumnProvider) { +public class ColumnProviderFactory { + public static ColumnProvider buildProvider(ColumnContext columnContext) { + String virtualColumnProvider = columnContext.getFieldSpec().getVirtualColumnProvider(); try { - return (VirtualColumnProvider) Class.forName(virtualColumnProvider).newInstance(); + // Use the preset virtualColumnProvider if available + if (virtualColumnProvider != null && !virtualColumnProvider + .equals(DefaultNullValueColumnProvider.class.getName())) { + return (ColumnProvider) Class.forName(virtualColumnProvider).newInstance(); + } + // Create the columnProvider that returns default null values based on the columnContext + return DefaultNullValueColumnProvider.class.getDeclaredConstructor(ColumnContext.class) + .newInstance(columnContext); Review comment: Didn't know this. updated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org