From commits-return-16568-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Thu Feb 27 20:31:25 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99887180181 for ; Thu, 27 Feb 2020 21:31:24 +0100 (CET) Received: (qmail 26074 invoked by uid 500); 27 Feb 2020 20:31:24 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 26063 invoked by uid 99); 27 Feb 2020 20:31:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2020 20:31:24 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig Message-ID: <158283548391.24237.38996373815892424.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 27 Feb 2020 20:31:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig URL: https://github.com/apache/incubator-pinot/pull/5073#issuecomment-586694558 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=h1) Report > Merging [#5073](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3126d56f7b4688f03bf1afdd9d13ff991376a762?src=pr&el=desc) will **decrease** coverage by `0.69%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5073/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5073 +/- ## =========================================== - Coverage 58.46% 57.76% -0.7% Complexity 12 12 =========================================== Files 1209 1196 -13 Lines 64605 63195 -1410 Branches 9508 9325 -183 =========================================== - Hits 37769 36505 -1264 + Misses 24067 23976 -91 + Partials 2769 2714 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/pinot/controller/api/resources/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0NvbnN0YW50cy5qYXZh) | `21.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ols/admin/command/OperateClusterConfigCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvT3BlcmF0ZUNsdXN0ZXJDb25maWdDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../controller/api/resources/PinotClusterConfigs.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90Q2x1c3RlckNvbmZpZ3MuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../tools/admin/command/AbstractBaseAdminCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWJzdHJhY3RCYXNlQWRtaW5Db21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0% <0%> (-96%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-53.85%)` | `0% <0%> (ø)` | | | [...che/pinot/core/startree/v2/StarTreeV2Metadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9TdGFyVHJlZVYyTWV0YWRhdGEuamF2YQ==) | `62.5% <0%> (-29.17%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | | | [...gregation/function/FastHLLAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GYXN0SExMQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `55.55% <0%> (-8.97%)` | `0% <0%> (ø)` | | | ... and [123 more](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=footer). Last update [3126d56...4dba420](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org