From commits-return-16531-archive-asf-public=cust-asf.ponee.io@pinot.apache.org  Wed Feb 26 23:46:32 2020
Return-Path: <commits-return-16531-archive-asf-public=cust-asf.ponee.io@pinot.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 60E2D18065C
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 27 Feb 2020 00:46:32 +0100 (CET)
Received: (qmail 1745 invoked by uid 500); 26 Feb 2020 23:46:31 -0000
Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pinot.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pinot.apache.org>
List-Post: <mailto:commits@pinot.apache.org>
List-Id: <commits.pinot.apache.org>
Reply-To: dev@pinot.apache.org
Delivered-To: mailing list commits@pinot.apache.org
Received: (qmail 1736 invoked by uid 99); 26 Feb 2020 23:46:31 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2020 23:46:31 +0000
From: GitBox <git@apache.org>
To: commits@pinot.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-pinot=5D_akshayrai_commented_on_a_cha?=
 =?utf-8?q?nge_in_pull_request_=235098=3A_=5BTE=5D_frontend_-_harleyjj/rca?=
 =?utf-8?q?_-_add_tooltip_for_Dimensions_tab_to_expl=E2=80=A6?=
Message-ID: <158276079170.27667.16278119213444549409.gitbox@gitbox.apache.org>
References: <pinot.5098.MDExOlB1bGxSZXF1ZXN0MzgwNTUxNTgw.gitbox@gitbox.apache.org>
In-Reply-To: <pinot.5098.MDExOlB1bGxSZXF1ZXN0MzgwNTUxNTgw.gitbox@gitbox.apache.org>
Date: Wed, 26 Feb 2020 23:46:31 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

akshayrai commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098#discussion_r384834962
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/components/cube-tooltip/template.hbs
 ##########
 @@ -0,0 +1,21 @@
+<div class="te-tooltip__body te-tooltip__body--large">
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Definition of Terms</span>
+  </div>
+  <p>CV: current value<br/>
+    PV: previous (baseline) value<br/>
+    SUM_CV: total value<br/>
+    SUM_PV: total previous (baseline) value
+  </p>
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Formulas</span>
+  </div>
+  <p>Percentage Change: (CV -PV) * 100 / PV<br/>
+    Change in Contribution: (CV/SUM_CV -PV/ SUM_PV) * 100<br/>
+    Contribution to Overall Change: (CV -PV) * 100 / (SUM_CV-SUM_PV)
 
 Review comment:
   Can you ensure there is a space before & after all the operators?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org