From commits-return-16116-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Sat Feb 8 15:30:23 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 350E018067F for ; Sat, 8 Feb 2020 16:30:23 +0100 (CET) Received: (qmail 17141 invoked by uid 500); 8 Feb 2020 15:30:22 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 17047 invoked by uid 99); 8 Feb 2020 15:30:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Feb 2020 15:30:22 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5039: Close Kafka consumer before building or downloading immutable segment Message-ID: <158117582233.32475.701101357939414767.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 08 Feb 2020 15:30:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mcvsubbu commented on a change in pull request #5039: Close Kafka consumer before building or downloading immutable segment URL: https://github.com/apache/incubator-pinot/pull/5039#discussion_r376715667 ########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ########## @@ -60,6 +63,11 @@ private SegmentBuildTimeLeaseExtender _leaseExtender; private RealtimeSegmentStatsHistory _statsHistory; private final Semaphore _segmentBuildSemaphore; + // Maintains a map for the partitionIds and its related semaphores, which is to prevent two different Kafka consumers Review comment: ```suggestion // Maintains a map of partitionIds to semaphores. The semaphore ensures that exactly one PartitionConsumer // instance consumes from any stream partition. In some streams, it is possible that having multiple consumers (with the same consumer name on the same host) consuming from the same stream partition can lead to bugs. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org