From commits-return-16095-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Fri Feb 7 23:55:43 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8DFC818060E for ; Sat, 8 Feb 2020 00:55:43 +0100 (CET) Received: (qmail 55374 invoked by uid 500); 7 Feb 2020 23:55:43 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 55365 invoked by uid 99); 7 Feb 2020 23:55:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2020 23:55:42 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5046: Re-design the broker routing Message-ID: <158111974280.12604.9216970705536415633.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 07 Feb 2020 23:55:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Jackie-Jiang commented on a change in pull request #5046: Re-design the broker routing URL: https://github.com/apache/incubator-pinot/pull/5046#discussion_r376660538 ########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/v2/segmentpruner/PartitionAwareSegmentPruner.java ########## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.broker.routing.v2.segmentpruner; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import javax.annotation.Nullable; +import org.apache.helix.AccessOption; +import org.apache.helix.ZNRecord; +import org.apache.helix.model.ExternalView; +import org.apache.helix.store.zk.ZkHelixPropertyStore; +import org.apache.pinot.common.metadata.ZKMetadataProvider; +import org.apache.pinot.common.metadata.segment.ColumnPartitionMetadata; +import org.apache.pinot.common.metadata.segment.SegmentPartitionMetadata; +import org.apache.pinot.common.request.BrokerRequest; +import org.apache.pinot.common.utils.CommonConstants; +import org.apache.pinot.common.utils.request.FilterQueryTree; +import org.apache.pinot.common.utils.request.RequestUtils; +import org.apache.pinot.core.data.partition.PartitionFunction; +import org.apache.pinot.core.data.partition.PartitionFunctionFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class PartitionAwareSegmentPruner implements SegmentPruner { Review comment: Added ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org