From commits-return-15981-archive-asf-public=cust-asf.ponee.io@pinot.apache.org  Wed Feb  5 18:28:25 2020
Return-Path: <commits-return-15981-archive-asf-public=cust-asf.ponee.io@pinot.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 8ABF018061A
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  5 Feb 2020 19:28:25 +0100 (CET)
Received: (qmail 99032 invoked by uid 500); 5 Feb 2020 18:28:24 -0000
Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pinot.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pinot.apache.org>
List-Post: <mailto:commits@pinot.apache.org>
List-Id: <commits.pinot.apache.org>
Reply-To: dev@pinot.apache.org
Delivered-To: mailing list commits@pinot.apache.org
Received: (qmail 99023 invoked by uid 99); 5 Feb 2020 18:28:24 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2020 18:28:24 +0000
From: GitBox <git@apache.org>
To: commits@pinot.apache.org
Subject: [GitHub] [incubator-pinot] elonazoulay commented on a change in pull request
 #4973: Add Avro Schema Registry Message Decoder
Message-ID: <158092730462.8680.2407757850299293033.gitbox@gitbox.apache.org>
References: <pinot.4973.MDExOlB1bGxSZXF1ZXN0MzYxODI0ODk3.gitbox@gitbox.apache.org>
In-Reply-To: <pinot.4973.MDExOlB1bGxSZXF1ZXN0MzYxODI0ODk3.gitbox@gitbox.apache.org>
Date: Wed, 05 Feb 2020 18:28:24 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r375430285
 
 

 ##########
 File path: pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml
 ##########
 @@ -0,0 +1,134 @@
+<?xml version="1.0"?>
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>pinot-input-format</artifactId>
+    <groupId>org.apache.pinot</groupId>
+    <version>0.3.0-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+
+  <artifactId>pinot-confluent-avro</artifactId>
+  <name>Pinot Avro</name>
+  <url>https://pinot.apache.org/</url>
+  <properties>
+    <pinot.root>${basedir}/../../..</pinot.root>
+    <kafka.lib.version>2.0.0</kafka.lib.version>
+    <confluent.version>5.3.1</confluent.version>
+  </properties>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-enforcer-plugin</artifactId>
+      </plugin>
+    </plugins>
+  </build>
+
+  <repositories>
+    <repository>
+      <id>confluent</id>
+      <url>http://packages.confluent.io/maven/</url>
+    </repository>
+  </repositories>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-avro-base</artifactId>
+    </dependency>
+
+    <dependency>
+      <groupId>org.apache.avro</groupId>
+      <artifactId>avro</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-api</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.mortbay.jetty</groupId>
+          <artifactId>jetty</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+
+    <dependency>
+      <groupId>org.apache.kafka</groupId>
+      <artifactId>kafka-clients</artifactId>
 
 Review comment:
   It's used by the schema registry client, as it stores schemas in a kafka topic, and uses the kafka client to retrieve and store metadata. It's a direct dependency of schema-registry client. If we exclude it then we get a ClassNotFound exception. So I would say leave it explicitly specified. Let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org