From commits-return-15913-archive-asf-public=cust-asf.ponee.io@pinot.apache.org  Tue Feb  4 01:25:19 2020
Return-Path: <commits-return-15913-archive-asf-public=cust-asf.ponee.io@pinot.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id AA21D180647
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  4 Feb 2020 02:25:18 +0100 (CET)
Received: (qmail 90239 invoked by uid 500); 4 Feb 2020 01:25:18 -0000
Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pinot.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pinot.apache.org>
List-Post: <mailto:commits@pinot.apache.org>
List-Id: <commits.pinot.apache.org>
Reply-To: dev@pinot.apache.org
Delivered-To: mailing list commits@pinot.apache.org
Received: (qmail 90229 invoked by uid 99); 4 Feb 2020 01:25:18 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2020 01:25:18 +0000
From: GitBox <git@apache.org>
To: commits@pinot.apache.org
Subject: [GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
 #4973: Add Avro Schema Registry Message Decoder
Message-ID: <158077951796.28142.7848224937131674946.gitbox@gitbox.apache.org>
References: <pinot.4973.MDExOlB1bGxSZXF1ZXN0MzYxODI0ODk3.gitbox@gitbox.apache.org>
In-Reply-To: <pinot.4973.MDExOlB1bGxSZXF1ZXN0MzYxODI0ODk3.gitbox@gitbox.apache.org>
Date: Tue, 04 Feb 2020 01:25:17 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374431904
 
 

 ##########
 File path: pinot-plugins/pinot-input-format/pinot-json/pom.xml
 ##########
 @@ -39,5 +39,11 @@
       <groupId>commons-lang</groupId>
       <artifactId>commons-lang</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-spi</artifactId>
 
 Review comment:
   I thought `pinot-spi` is in `pinot-plugins` pom (https://github.com/apache/incubator-pinot/blob/master/pinot-plugins/pom.xml#L50) so you don't need to put it here.
   Maybe to rebase from current master?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org