From commits-return-15897-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Mon Feb 3 23:24:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 08C69180647 for ; Tue, 4 Feb 2020 00:24:25 +0100 (CET) Received: (qmail 4080 invoked by uid 500); 3 Feb 2020 23:24:25 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 4067 invoked by uid 99); 3 Feb 2020 23:24:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 23:24:25 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names Message-ID: <158077226537.5266.1563672109649050085.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 23:24:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374397320 ########## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java ########## @@ -120,6 +120,10 @@ private void convertSelectList(PinotQuery pinotQuery, BrokerRequest brokerReques List aggregationInfoList = null; for (Expression expression : pinotQuery.getSelectList()) { ExpressionType type = expression.getType(); + if (type == ExpressionType.FUNCTION && expression.getFunctionCall().getOperator().equalsIgnoreCase(SqlKind.AS.toString())) { Review comment: What is the SQL standard for `AS` keyword? Can it work on `FUNCTION` and `LITERAL`? If not, we should add sanity check here to block the query. The query should always to valid when it goes to the query engine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org