From commits-return-15893-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Mon Feb 3 22:40:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD628180647 for ; Mon, 3 Feb 2020 23:40:06 +0100 (CET) Received: (qmail 50213 invoked by uid 500); 3 Feb 2020 22:40:06 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 50204 invoked by uid 99); 3 Feb 2020 22:40:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 22:40:06 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] jackjlli commented on issue #5039: Close Kafka consumer before building or downloading immutable segment Message-ID: <158076960605.19318.5245751850761338974.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 22:40:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jackjlli commented on issue #5039: Close Kafka consumer before building or downloading immutable segment URL: https://github.com/apache/incubator-pinot/pull/5039#issuecomment-581653792 This PR does consider the case when Helix transition to ONLINE comes. There is only one host can win the change to commit. For the winner, it's ok to close the consumer since its consumption job is done. For the rest, after catching up the offset if needed, it's ok to close the consumer; if it's needed to download the segment, the current consumer is also unnecessary. Thus, it's OK to close it before building or downloading the segment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org