From commits-return-15868-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Mon Feb 3 18:16:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BFE2D180647 for ; Mon, 3 Feb 2020 19:16:53 +0100 (CET) Received: (qmail 26948 invoked by uid 500); 3 Feb 2020 18:16:53 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 26938 invoked by uid 99); 3 Feb 2020 18:16:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 18:16:53 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance Message-ID: <158075381304.15882.1170472185486827226.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 18:16:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-581546277 Please update the commit message. Also, i am not sure where (or even how) to document the fact that if multiple updates happen, not all of them will be taken. For now, we can add that as a part of the commit message at least, I suppose. thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org