pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments
Date Fri, 28 Feb 2020 08:06:53 GMT
haibow commented on a change in pull request #4954: Support schema evolution for consuming
segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r385555977
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
 ##########
 @@ -155,27 +155,37 @@ public void updateDefaultColumns()
    *
    * @return Action Map for each column.
    */
-  private Map<String, DefaultColumnAction> computeDefaultColumnActionMap() {
+  public static Map<String, DefaultColumnAction> computeDefaultColumnActionMap(Schema
schema,
 
 Review comment:
   Removed unused code for the consuming segment. I kept some changes for the unit tests that
I added for the committed segment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message