pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5097: [TE][subscription] destroy jira connections after use
Date Thu, 27 Feb 2020 18:30:30 GMT
jihaozh commented on a change in pull request #5097: [TE][subscription] destroy jira connections
after use
URL: https://github.com/apache/incubator-pinot/pull/5097#discussion_r385292732
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
 ##########
 @@ -54,6 +54,8 @@ public DetectionAlertScheme(DetectionAlertConfigDTO subsConfig, DetectionAlertFi
 
   public abstract void run() throws Exception;
 
+  public abstract void destroy() throws Exception;
 
 Review comment:
   Can we put a default implementation here so that not all subclasses need to implement this
interface? 
   
   Define it like this here, and only overrides it in Jira alerter. So that no changes is
needed for other alerters.
   ```
     public void destroy() {
       // do nothing
     }
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message