pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments
Date Thu, 27 Feb 2020 01:20:22 GMT
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming
segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r384863289
 
 

 ##########
 File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
 ##########
 @@ -197,7 +201,15 @@ private void reloadSegment(String tableNameWithType, SegmentMetadata
segmentMeta
 
     File indexDir = segmentMetadata.getIndexDir();
     if (indexDir == null) {
-      LOGGER.info("Skip reloading REALTIME consuming segment: {} in table: {}", segmentName,
tableNameWithType);
+      if (!_instanceDataManagerConfig.shouldReloadConsumingSegment()) {
+        LOGGER.info("Skip reloading REALTIME consuming segment: {} in table: {}", segmentName,
tableNameWithType);
+        return;
+      }
+      LOGGER.info("Try reloading REALTIME consuming segment: {} in table: {}", segmentName,
tableNameWithType);
+      SegmentMetadataImpl segmentMetadataImpl = (SegmentMetadataImpl) segmentMetadata;
+      MutableSegmentImpl mutableSegment = (MutableSegmentImpl) (_tableDataManagerMap.get(tableNameWithType)
+          .acquireSegment(segmentMetadataImpl.getName()).getSegment());
 
 Review comment:
   Where are you releasing the segment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message