pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
Date Wed, 26 Feb 2020 23:58:50 GMT
cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip
for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098#discussion_r384839256
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/partials/rootcause/dimensions/template.hbs
 ##########
 @@ -3,6 +3,12 @@
     {{#subtablist.tab name="heatmap"}}Heatmap{{/subtablist.tab}}
     {{#subtablist.tab name="table"}}Table{{/subtablist.tab}}
     {{#subtablist.tab name="algorithm"}}Algorithm{{/subtablist.tab}}
+    <span>
+      <i class="glyphicon glyphicon-question-sign"></i>
+      {{#bs-popover placement="bottom" title="What do the options mean?"}}
+        {{cube-tooltip}}
+      {{/bs-popover}}
+    </span>
 
 Review comment:
   Is it possible to put this question sign next to
   1. "Color heatmap by" when the user selects the heatmap tab and
   2. At the end of the cell "Contribution to Overall Change" and "Change in Contribution?"
when in the Algorithm tab.
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message