pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
Date Tue, 04 Feb 2020 01:25:17 GMT
fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374431904
 
 

 ##########
 File path: pinot-plugins/pinot-input-format/pinot-json/pom.xml
 ##########
 @@ -39,5 +39,11 @@
       <groupId>commons-lang</groupId>
       <artifactId>commons-lang</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-spi</artifactId>
 
 Review comment:
   I thought `pinot-spi` is in `pinot-plugins` pom (https://github.com/apache/incubator-pinot/blob/master/pinot-plugins/pom.xml#L50)
so you don't need to put it here.
   Maybe to rebase from current master?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message