pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] jackjlli edited a comment on issue #5039: Close Kafka consumer before building or downloading immutable segment
Date Mon, 03 Feb 2020 22:44:16 GMT
jackjlli edited a comment on issue #5039: Close Kafka consumer before building or downloading
immutable segment
URL: https://github.com/apache/incubator-pinot/pull/5039#issuecomment-581653792
 
 
   This PR does consider the case when Helix transition to ONLINE comes.
   
   There is only one host can win the change to commit. 
   For the winner, it's ok to close the consumer since its consumption job is done. 
   For the rest, they will get the Helix transition to ONLINE.
   If it's needed to catch up with the offset, it's ok to close the consumer after they finished
catching up; if it's needed to download the segment, the current consumer is also unnecessary
to leave it open.
   
   Thus, it's OK to close it before building or downloading the segment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message