pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Coveney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-2735) Add a pig.version.prefix property in build.xml to easily override with a build number
Date Fri, 01 Jun 2012 17:44:22 GMT

    [ https://issues.apache.org/jira/browse/PIG-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287559#comment-13287559
] 

Jonathan Coveney commented on PIG-2735:
---------------------------------------

ALTHOUGH, if you're feeling munificent, it may be worth going the extra step and updating
how we parse out version in Main.java
{code}

            version = attr.getValue("Implementation-Version");
            svnRevision = attr.getValue("Svn-Revision");
            buildTime = attr.getValue("Build-TimeStamp");
            String[] split = version.split("-")[0].split("\\.");
            majorVersion=split[0];
            minorVersion=split[1];
            patchVersion=split[2];
{code}

You could clean this up to make patchVersion pick up the pig.version.suffix, and so on. This
may involve writing that in a clearer way to the manifest.
                
> Add a pig.version.prefix property in build.xml to easily override with a build number
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-2735
>                 URL: https://issues.apache.org/jira/browse/PIG-2735
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Julien Le Dem
>            Assignee: Julien Le Dem
>         Attachments: PIG-2735.patch
>
>
> This can be used as follows in Jenkins:
> ant -Dpig.version.suffix=+${BUILD_NUMBER} jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message