pig-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dvrya...@apache.org
Subject svn commit: r1399054 - in /pig/trunk: CHANGES.txt test/org/apache/pig/test/TestParamSubPreproc.java test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
Date Wed, 17 Oct 2012 00:23:12 GMT
Author: dvryaboy
Date: Wed Oct 17 00:23:11 2012
New Revision: 1399054

URL: http://svn.apache.org/viewvc?rev=1399054&view=rev
Log:
PIG-2943: DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health

Modified:
    pig/trunk/CHANGES.txt
    pig/trunk/test/org/apache/pig/test/TestParamSubPreproc.java
    pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java

Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1399054&r1=1399053&r2=1399054&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Wed Oct 17 00:23:11 2012
@@ -24,6 +24,8 @@ INCOMPATIBLE CHANGES
 
 IMPROVEMENTS
 
+PIG-2943: DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health
(jgordon via dvryaboy)
+
 PIG-2966: Test failures on CentOS 6 because MALLOC_ARENA_MAX is not set (cheolsoo via sms)
 
 PIG-2793: Pig test: add utils to simplify testing on Windows (jgordon via gates)

Modified: pig/trunk/test/org/apache/pig/test/TestParamSubPreproc.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/test/TestParamSubPreproc.java?rev=1399054&r1=1399053&r2=1399054&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/test/TestParamSubPreproc.java (original)
+++ pig/trunk/test/org/apache/pig/test/TestParamSubPreproc.java Wed Oct 17 00:23:11 2012
@@ -1198,7 +1198,7 @@ public class TestParamSubPreproc extends
             pigOStream = new FileWriter(basedir + "/output1.pig");
 
             String[] arg = {"date=`perl -e 'print \"20080228\n20070101\"' | head -n 1`"};
-            if (System.getProperty("os.name").toUpperCase().startsWith("WINDOWS"))
+            if (Util.WINDOWS)
                 arg[0] = "date=`perl -e 'print \\\"20080228\n20070101\\\"' | head -n 1`";
             String[] argFiles = null;
             ps.genSubstitutedFile(pigIStream , pigOStream , arg , argFiles);

Modified: pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java?rev=1399054&r1=1399053&r2=1399054&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java (original)
+++ pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java Wed Oct 17 00:23:11
2012
@@ -144,7 +144,7 @@ public class TestTypeCheckingValidatorNe
 
     private static final String simpleEchoStreamingCommand;
     static {
-        if (System.getProperty("os.name").toUpperCase().startsWith("WINDOWS"))
+        if (Util.WINDOWS)
             simpleEchoStreamingCommand = "perl -ne 'print \\\"$_\\\"'";
         else
             simpleEchoStreamingCommand = "perl -ne 'print \"$_\"'";



Mime
View raw message