From dev-return-52217-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jun 1 09:25:30 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E14EC18063A for ; Fri, 1 Jun 2018 09:25:29 +0200 (CEST) Received: (qmail 69877 invoked by uid 500); 1 Jun 2018 07:25:28 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 69859 invoked by uid 99); 1 Jun 2018 07:25:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 07:25:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2A993E0BBD; Fri, 1 Jun 2018 07:25:28 +0000 (UTC) From: twdsilva To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ... Content-Type: text/plain Message-Id: <20180601072528.2A993E0BBD@git1-us-west.apache.org> Date: Fri, 1 Jun 2018 07:25:28 +0000 (UTC) Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r192316117 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2967,6 +2982,11 @@ protected PhoenixConnection upgradeSystemCatalogIfRequired(PhoenixConnection met HTableDescriptor.SPLIT_POLICY + "='" + SystemStatsSplitPolicy.class.getName() +"'" ); } + // TODO set the version for which the following upgrade code runs correct + if (currentServerSideTableTimeStamp < MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0) { --- End diff -- Done ---