phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4449) Incorrect behavior of sqlline after PHOENIX-3567
Date Wed, 13 Dec 2017 01:11:00 GMT


Hadoop QA commented on PHOENIX-4449:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 1a19d1ecbd38f2b7ee406df8efa05d29f685ef57.
  ATTACHMENT ID: 12901780

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Incorrect behavior of sqlline after PHOENIX-3567
> ------------------------------------------------
>                 Key: PHOENIX-4449
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.10.0, 4.13.0, 5.0.0
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 5.0.0, 4.14.0
>         Attachments: PHOENIX-4449.001.patch, PHOENIX-4449.002.patch
> In PHOENIX-3567 we have introduced a usage of argparse in sqlline as well as some default
values for the parameters. That's not good because of:
> 1. argparse is not a default package in old versions of python like 2.6.6 which is using
in centos 6 distribution. 
> 2. We should not set a default value for zookeeper parent because if it's not specified
in the command line, those values should be obtained from hbase client (hbase-site.xml or
default values if it's not in the classpath).

This message was sent by Atlassian JIRA

View raw message