Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 5 Jan 2016 05:37:39 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12910283.1446628385000.17542.1451972259864@Atlassian.JIRA>
In-Reply-To: <JIRA.12910283.1446628385000@Atlassian.JIRA>
References: <JIRA.12910283.1446628385000@Atlassian.JIRA>
 <JIRA.12910283.1446628385867@arcas>
Subject: [jira] [Commented] (PHOENIX-2368) Call Driver.accept() in
 Driver.getConnection and return null if false
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082414#comment-15082414 ] 

James Taylor commented on PHOENIX-2368:
---------------------------------------

I think for this JIRA, you should call acceptURL(url) and return null outside of any locking. Only if acceptURL passes, would you proceed with the existing logic/locking.

> Call Driver.accept() in Driver.getConnection and return null if false
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-2368
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2368
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>              Labels: SFDC, newbie
>             Fix For: 4.7.0
>
>
> The driver should return "null" if it realizes it is the wrong kind of driver to connect to the given URL.
> Your driver is throwing an exception instead of returning null.
> Here's the start of a test case:
> {code}
> public static void main(String[] args) throws Exception {
>     Class.forName(PhoenixDriver.class.getName());
>     PhoenixDriver d = (PhoenixDriver) DriverManager.getDriver("jdbc:phoenix");
>     d.close();
>     DriverManager.getConnection("any text whatever you want to put here");
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)