openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] mcdan commented on a change in pull request #4754: Mcdan/truncate keep running
Date Mon, 25 Nov 2019 19:49:25 GMT
mcdan commented on a change in pull request #4754: Mcdan/truncate keep running
URL: https://github.com/apache/openwhisk/pull/4754#discussion_r350386045
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala
 ##########
 @@ -62,40 +63,47 @@ protected[core] object ActivationResponse extends DefaultJsonProtocol
{
   val ApplicationError = 1 // action ran but there was an error and it was handled
   val DeveloperError = 2 // action ran but failed to handle an error, or action did not run
and failed to initialize
   val WhiskError = 3 // internal system error
+  val Truncated = 4 // action ran correctly, but returned a response that was too large
 
 Review comment:
   Okay, seems like we're losing information in the error handling that could be useful.
   
   For example the activation storage may want to not persist huge responses but application
errors maybe more interesting. To do this they'll need to now parse the error string which
doesn't have any exported contract, but perhaps there is another path for detecting that which
I don't know about.
   
   I'll back it out the new code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message