openoffice-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [Issue 124951] insert graphic from gallery is inserted as linked graphic by default
Date Thu, 26 Jun 2014 14:09:52 GMT

Armin Le Grand <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #4 from Armin Le Grand <> ---
Reason is that the ExecuteDropEvent feeded to Window::ExecuteDrop has
mnAction==5 already set. The mechanism starts at GalleryTheme::StartDrag where
as 2nd parameter the allowed actions (here DND_ACTION_COPY|DND_ACTION_LINK) is
used which is 5.
On Windows there is system-dependent code in project transfer which filters
this allowed actions using the current pressed keys (see
dtrans/source/win32.dnd:461 DropTarget::Drop and how it uses
'getFilteredActions' to reduce the allowed DND_ACTION* to the concrete ones
depending on pressed keys).

@Herbert: On Mac I could *not* find system-dependent code to reduce from the
allowed flags to the current flags, thus '5' (or copy *and* link) stay and will
be used in the drop implementations. What needs to be filled somewhere with the
filtered value is a
::com::sun::star::datatransfer::dnd::DropTargetDropEvent.DropAction. Maybe that
code is missing...?
I found DropTarget::performDragOperation in vcl where mSelectedDropAction seems
to be used, but I do not know if the mentioned filtering is done.

You are receiving this mail because:
You are watching all issue changes.

View raw message