Mailing-List: contact dev-help@openoffice.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openoffice.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Message-ID: <5397936B.5070802@apache.org>
Date: Wed, 11 Jun 2014 01:23:23 +0200
From: Andrea Pescetti <pescetti@apache.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: dev@openoffice.apache.org
Subject: Re: Portuguese download broken
References: 
 <CAJ5Tvfbc0BzZiVMqh96CsJHPt8J_0T1dh=RguNCUKS=xnQwjNw@mail.gmail.com>
	<5392EB64.6030005@wtnet.de>	<5393004F.2040507@wtnet.de>
 <CAJ5TvfYfSnCbHvL1zm_fgH2xtMcKp5YEpiYQrEhYFLuVNV7LZQ@mail.gmail.com>
 <53943ECB.8080107@apache.org> <53961CFE.4080009@wtnet.de>
 <539622B6.8060001@gmail.com> <53962573.2020600@wtnet.de>
 <539627AB.9000701@gmail.com> <53971A14.2000108@wtnet.de>
In-Reply-To: <53971A14.2000108@wtnet.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Marcus (OOo) wrote:
> It's easier than thought as only the following has to be done:
> - Add the following 4 files back to the main download area:
>    - download.js
>    - globalvars.js
>    - exceptions.css
>    - release_matrix.js
> - Rename the new files with adding something (e.g., "download2.js") to
>    separate from the old files.

This will cause some caching issues (for those who have already used the 
new download page) but indeed it seems not so bad.

> - Change the file references in the "head" part of the "index.html" in
>    the main download webpage, so that the new files will be used.

OK, unless you wish to rename the old ones (to download_old.js and such) 
if this is still easy, since we may want to actually get rid of the old 
mechanism in favor of the new one.

> - Delete the added "Click this temporary link to download"
>    text box in every localized "index.html" file.

For my commits, this means reverting
http://svn.apache.org/viewvc?view=revision&revision=1601211
http://svn.apache.org/viewvc?view=revision&revision=1601213
Of course, feel free to revert both when replacing them with a better 
solution.

> Now the golden question: :-)
> Do we want to go on with the temporary way?
> Or change back to the old One-Click-Download behavior?

Could we go back to the old behavior (whatever the file names) but then 
try and encapsulate all logic differently?

The most difficult part is that one just wants to localize the page, but 
still there's a lot of JavaScript around. From a maintenance point of 
view, I would prefer to have a "createDownloadDiv(var strings)" function 
that takes an array of all strings needed to build the localized div and 
returns the div markup. This would simplify a translator's work, since 
they would only have to translate a long but understandable function 
call. If this is unclear I can make an example. And this would also 
guarantee that we can adjust it more easily.

> Furthermore, I don't like the idea of a static webpage of this size. It
> will become bigger with every new released language. I've done the
> current improvements to avoid this piece of effort. ;-)

If we really want to have a webpage to serve all needs of people who 
disable technologies, we could build other.html with a script that scans 
the files tree and simply outputs a minimal table. But I don't know if 
this is worth the effort.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org