Return-Path: Delivered-To: apmail-ofbiz-commits-archive@www.apache.org Received: (qmail 27002 invoked from network); 28 Feb 2011 14:46:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 28 Feb 2011 14:46:23 -0000 Received: (qmail 36337 invoked by uid 500); 28 Feb 2011 14:46:22 -0000 Delivered-To: apmail-ofbiz-commits-archive@ofbiz.apache.org Received: (qmail 36155 invoked by uid 500); 28 Feb 2011 14:46:19 -0000 Mailing-List: contact commits-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list commits@ofbiz.apache.org Received: (qmail 36144 invoked by uid 99); 28 Feb 2011 14:46:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Feb 2011 14:46:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Feb 2011 14:46:18 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 51B7D23889E0; Mon, 28 Feb 2011 14:45:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1075356 - /ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java Date: Mon, 28 Feb 2011 14:45:58 -0000 To: commits@ofbiz.apache.org From: erwan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110228144558.51B7D23889E0@eris.apache.org> Author: erwan Date: Mon Feb 28 14:45:57 2011 New Revision: 1075356 URL: http://svn.apache.org/viewvc?rev=1075356&view=rev Log: String test should be using .equals instead of == Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java?rev=1075356&r1=1075355&r2=1075356&view=diff ============================================================================== --- ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java (original) +++ ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java Mon Feb 28 14:45:57 2011 @@ -68,7 +68,7 @@ public class ImportProductHelper { tmpProductGV = delegator.findByPrimaryKey("Product", UtilMisc .toMap("productId", productId)); if (tmpProductGV != null - && tmpProductGV.getString("productId") == productId) + && productId.equals(tmpProductGV.getString("productId"))) productExists = true; } catch (GenericEntityException e) { Debug.logError("Problem in reading data of product", module);