From issues-return-96726-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon May 4 14:46:14 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE008180608 for ; Mon, 4 May 2020 16:46:13 +0200 (CEST) Received: (qmail 35096 invoked by uid 500); 4 May 2020 14:46:13 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 35087 invoked by uid 99); 4 May 2020 14:46:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 14:46:13 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_msharee9_commented_on_a_change_?= =?utf-8?q?in_pull_request_=23775=3A_MINIFICPP-965_Add_other_supported_relat?= =?utf-8?q?ionships_to_InvokeHTTP_processor=2E?= Message-ID: <158860357322.26397.10950209885263847474.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 14:46:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: msharee9 commented on a change in pull request #775: URL: https://github.com/apache/nifi-minifi-cpp/pull/775#discussion_r419491795 ########## File path: extensions/http-curl/client/HTTPClient.h ########## @@ -124,11 +135,11 @@ class HTTPClient : public BaseHTTPClient, public core::Connectable { bool setMinimumSSLVersion(SSLVersion minimum_version) override; - void setKeepAliveProbe(long probe){ + void setKeepAliveProbe(std::chrono::milliseconds probe){ keep_alive_probe_ = probe; } - void setKeepAliveIdle(long idle){ Review comment: Agree. especially when they are public members. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org