From issues-return-96724-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon May 4 14:28:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E28E1180608 for ; Mon, 4 May 2020 16:28:38 +0200 (CEST) Received: (qmail 89787 invoked by uid 500); 4 May 2020 14:28:38 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 89778 invoked by uid 99); 4 May 2020 14:28:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 14:28:38 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_szaszm_commented_on_pull_reques?= =?utf-8?q?t_=23773=3A_MINIFICPP-1202_-_Extend_interface_and_add_new_tests_f?= =?utf-8?q?or_MinifiConcurrentQueue?= Message-ID: <158860251828.26397.1812108523189785687.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 14:28:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: szaszm commented on pull request #773: URL: https://github.com/apache/nifi-minifi-cpp/pull/773#issuecomment-623497918 Thanks for your effort towards fixing all of the issues we pointed out. The consume family of member functions will provide a significant improvement in the usability of the class. I also like that the unit tests now utilize sections. As I mentioned [here](https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r419476317), feel free to question my code review comments anytime, as oftentimes they are just mere ideas to keep things simple/short, and may be missing some important point. I'll do another review of the latest changes soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org