From issues-return-96711-archive-asf-public=cust-asf.ponee.io@nifi.apache.org  Mon May  4 10:58:35 2020
Return-Path: <issues-return-96711-archive-asf-public=cust-asf.ponee.io@nifi.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 07A59180608
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  4 May 2020 12:58:34 +0200 (CEST)
Received: (qmail 80026 invoked by uid 500); 4 May 2020 10:58:34 -0000
Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@nifi.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@nifi.apache.org>
List-Post: <mailto:issues@nifi.apache.org>
List-Id: <issues.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list issues@nifi.apache.org
Received: (qmail 80017 invoked by uid 99); 4 May 2020 10:58:34 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 10:58:34 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: issues@nifi.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_szaszm_commented_on_a_change_in?=
 =?utf-8?q?_pull_request_=23773=3A_MINIFICPP-1202_-_Extend_interface_and_add?=
 =?utf-8?q?_new_tests_for_MinifiConcurrentQueue?=
Message-ID: <158858991418.26397.4472030609985031660.asfpy@gitbox.apache.org>
Date: Mon, 04 May 2020 10:58:34 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <nifi-minifi-cpp.773.MDExOlB1bGxSZXF1ZXN0NDA5NTgyNDU2.gitbox@gitbox.apache.org>
In-Reply-To: <nifi-minifi-cpp.773.MDExOlB1bGxSZXF1ZXN0NDA5NTgyNDU2.gitbox@gitbox.apache.org>


szaszm commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r419356467



##########
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##########
@@ -21,14 +21,49 @@
 #include <deque>
 #include <mutex>
 #include <condition_variable>
+#include <utility>
 #include <stdexcept>
+#include <type_traits>
 
 namespace org {
 namespace apache {
 namespace nifi {
 namespace minifi {
 namespace utils {
 
+namespace detail {

Review comment:
       +1 for extracting the `void_t` implementation but -1 for `TryMoveCall` (at least until we need it elsewhere).
   If `void_t` is extracted, please adapt the partial detection idiom impl above `StringUtils::join_pack` to use the extracted one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org