From issues-return-96701-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Sun May 3 23:24:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E772E180621 for ; Mon, 4 May 2020 01:24:35 +0200 (CEST) Received: (qmail 72679 invoked by uid 500); 3 May 2020 23:24:35 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 72670 invoked by uid 99); 3 May 2020 23:24:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 May 2020 23:24:35 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_MikeThomsen_commented_on_a_change_in_pull_?= =?utf-8?q?request_=234231=3A_NIFI-7037_Split_off_username_and_password_fiel?= =?utf-8?q?ds_for_GetMongo_processor?= Message-ID: <158854827490.26397.4882761980177643337.asfpy@gitbox.apache.org> Date: Sun, 03 May 2020 23:24:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: MikeThomsen commented on a change in pull request #4231: URL: https://github.com/apache/nifi/pull/4231#discussion_r419174198 ########## File path: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java ########## @@ -271,4 +302,59 @@ public void onTrigger(final ProcessContext context, final ProcessSession session } } + + @OnScheduled + public void createClient(ProcessContext context) throws IOException { Review comment: @alopresto We started moving toward using a controller service to manage the client connection I think ~3 releases ago. The best place for these changes might be there, so we can start moving toward deprecating per-processor connection management altogether. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org