nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] szaszm commented on pull request #773: MINIFICPP-1202 - Extend interface and add new tests for MinifiConcurrentQueue
Date Mon, 04 May 2020 14:28:38 GMT

szaszm commented on pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#issuecomment-623497918


   Thanks for your effort towards fixing all of the issues we pointed out. The consume family
of member functions will provide a significant improvement in the usability of the class.
I also like that the unit tests now utilize sections.
   
   As I mentioned [here](https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r419476317),
feel free to question my code review comments anytime, as oftentimes they are just mere ideas
to keep things simple/short, and may be missing some important point.
   
   I'll do another review of the latest changes soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message