From issues-return-84678-archive-asf-public=cust-asf.ponee.io@nifi.apache.org  Tue Sep 10 13:31:19 2019
Return-Path: <issues-return-84678-archive-asf-public=cust-asf.ponee.io@nifi.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id CE2E9180642
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 10 Sep 2019 15:31:18 +0200 (CEST)
Received: (qmail 97597 invoked by uid 500); 10 Sep 2019 13:31:18 -0000
Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@nifi.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@nifi.apache.org>
List-Post: <mailto:issues@nifi.apache.org>
List-Id: <issues.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list issues@nifi.apache.org
Received: (qmail 97588 invoked by uid 99); 10 Sep 2019 13:31:18 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Sep 2019 13:31:18 +0000
From: GitBox <git@apache.org>
To: issues@nifi.apache.org
Subject: [GitHub] [nifi] scottyaslan commented on a change in pull request #3710:
 NIFI-6641 - support read only mode for parameter context dialog
Message-ID: <156812227821.16932.10150115615512467601.gitbox@gitbox.apache.org>
Date: Tue, 10 Sep 2019 13:31:18 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

scottyaslan commented on a change in pull request #3710: NIFI-6641 - support read only mode for parameter context dialog
URL: https://github.com/apache/nifi/pull/3710#discussion_r322740620
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/new-parameter-context-dialog.jsp
 ##########
 @@ -31,13 +31,15 @@
                     <div class="setting">
                         <div class="setting-name">Name</div>
                         <div id="parameter-context-name-container" class="setting-field">
-                            <input type="text" id="parameter-context-name" name="parameter-context-name"/>
+                            <input type="text" id="parameter-context-name" class="edit-mode" name="parameter-context-name"/>
+                            <div id="parameter-context-name-read-only" class="read-only"></div>
 
 Review comment:
   This needs ellipsis and a title attr for the tooltip. The Id field will also need this...
   
   ![Screen Shot 2019-09-10 at 9 21 44 AM](https://user-images.githubusercontent.com/6797571/64617916-46138c80-d3ad-11e9-807f-c200443766ce.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services