nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] phrocker commented on issue #645: MINIFICPP-1028 - http url parsing without port fails
Date Tue, 10 Sep 2019 13:14:11 GMT
phrocker commented on issue #645: MINIFICPP-1028 - http url parsing without port fails
URL: https://github.com/apache/nifi-minifi-cpp/pull/645#issuecomment-529928433
 
 
   > > Thanks! We have this in a few places throughout the project, but those may be
for testing. We've had this issue for other cases that tripped us up -- makes me wonder if
we could just use civetweb for something like this.
   > 
   > cURL has a dedicated URL API, that can parse URLs: https://github.com/curl/curl/blob/master/include/curl/urlapi.h
   > However, that would require everything that would want to use this to depend on cURL,
and while I am all for not using homecooked parsers, I am not sure whether that's something
we want.
   
   Yeah a few of us previously discussed breaking that out -- then someone suggested using
civet's parsers. Civet, at the time, was not an extension; however, now that we have a 'classloader'
like capability we could specialize the parser based on extensions and have URLParser use
a variant that relies on curl if it is built. cURL support will be quite prevalent, so we
would rely on their more tested parser. That would mean we must still maintain ours, but have
clear documentation that using our parser may have risk versus the one in curl-land. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message