nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #643: MINIFICPP-14: Prune class names. Add option to config
Date Mon, 09 Sep 2019 10:30:02 GMT
phrocker commented on a change in pull request #643: MINIFICPP-14: Prune class names. Add option
to config
URL: https://github.com/apache/nifi-minifi-cpp/pull/643#discussion_r322170345
 
 

 ##########
 File path: libminifi/src/utils/ClassUtils.cpp
 ##########
 @@ -0,0 +1,51 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "utils/ClassUtils.h"
+#include "utils/StringUtils.h"
+#include <iostream>
+#include <string>
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+void ClassUtils::shortenClassName(const std::string &class_name, std::string &out)
{
 
 Review comment:
   There are several pros and cons but following suit for some of the other API calls I should
have returned true/false if shortening occurred. I like the idea of using output variables
and since I'm already following other API utils classes I'll make that change. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message