From issues-return-82046-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Jul 31 07:39:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BFE87180645 for ; Wed, 31 Jul 2019 09:39:02 +0200 (CEST) Received: (qmail 57772 invoked by uid 500); 31 Jul 2019 07:39:02 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 57762 invoked by uid 99); 31 Jul 2019 07:39:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jul 2019 07:39:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 19D21E2F8A for ; Wed, 31 Jul 2019 07:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 62CDF2663B for ; Wed, 31 Jul 2019 07:39:00 +0000 (UTC) Date: Wed, 31 Jul 2019 07:39:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@nifi.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896860#comment-16896860 ] ASF subversion and git services commented on NIFI-6490: ------------------------------------------------------- Commit 1d22e8a86d001540bb86d017a9139393778628cb in nifi's branch refs/heads/master from Alessandro D'Armiento [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1d22e8a ] NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS Unified unit tests Added custom validation cases for MIN_RECORDS and MAX_RECORDS enforcing they are greater than zero. While MIN_RECORDS > 0 can fail individually, MAX_RECORDS > 0 validator cannot fail without having also at least another validation step (either the MIN_RECORDS > 0 or the MAX_RECORDS > MIN_RECORDS) to fail, since MIN_RECORDS is a required property with default value 1 This closes #3607. Signed-off-by: Koji Kawamura > MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language > ------------------------------------------------------------------------------------------------------ > > Key: NIFI-6490 > URL: https://issues.apache.org/jira/browse/NIFI-6490 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Affects Versions: 1.9.2 > Reporter: Alessandro D'Armiento > Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > h2. Current Situation > MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how many records a merged bin can contain. > These properties, however, do not support expression language and cannot be inserted from variables. > h2. Improvement Proposal > Accept variable registry in these properties -- This message was sent by Atlassian JIRA (v7.6.14#76016)