From issues-return-80800-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Jul 10 00:43:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF63F18062B for ; Wed, 10 Jul 2019 02:43:13 +0200 (CEST) Received: (qmail 74739 invoked by uid 500); 10 Jul 2019 00:43:13 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 74730 invoked by uid 99); 10 Jul 2019 00:43:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jul 2019 00:43:13 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi] avseq1234 commented on a change in pull request #3575: NIFI-6271, fix incoming flowfile attributes don't copy into output flowfiles when Output Batch Size is set Message-ID: <156271938967.18613.9232837841505716111.gitbox@gitbox.apache.org> Date: Wed, 10 Jul 2019 00:43:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit avseq1234 commented on a change in pull request #3575: NIFI-6271, fix incoming flowfile attributes don't copy into output flowfiles when Output Batch Size is set URL: https://github.com/apache/nifi/pull/3575#discussion_r301847285 ########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java ########## @@ -312,12 +312,6 @@ public void onTrigger(final ProcessContext context, final ProcessSession session // If we've reached the batch size, send out the flow files if (outputBatchSize > 0 && resultSetFlowFiles.size() >= outputBatchSize) { session.transfer(resultSetFlowFiles, REL_SUCCESS); - // Need to remove the original input file if it exists - if (fileToProcess != null) { - session.remove(fileToProcess); - fileToProcess = null; - } - session.commit(); Review comment: I modify the code because the way that I mentioned before will break some test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services