nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mr TheSegfault (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MINIFICPP-985) Implement listvalidators
Date Thu, 25 Jul 2019 15:17:00 GMT

    [ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892867#comment-16892867
] 

Mr TheSegfault edited comment on MINIFICPP-985 at 7/25/19 3:16 PM:
-------------------------------------------------------------------

Why would this be a nightmare for C2? It's only the manifest on registration ( for our default
coap protocol ). and we'll hopefully migrate rest there at some point ( or make that configurable
)

 

If you have a specific set of values we shouldn't validate against all possible combination
( for example if we accept 4 and 3.3 ) why would you use an integer and float validator? That
seems like you would still need to ensure you are only allowing 4 and 3.3, so validation doesn't
seem right.  Are there more concrete examples in the kafka processor?

 

List validators worry me because they allow multiple modes of validation where one will do,
and if the allowable value set can be built easily, then that is preferable. I'm sure there
could be cases where a list validator is necessary but it allows the complexity of separate
validators, which I'm suspect of us needing.

 


was (Author: phrocker):
Why would this be a nightmare for C2? It's only the manifest on registration ( for our default
coap protocol ).

 

If you have a specific set of values we shouldn't validate against all possible combination
( for example if we accept 4 and 3.3 ) why would you use an integer and float validator? That
seems like you would still need to ensure you are only allowing 4 and 3.3, so validation doesn't
seem right.  Are there more concrete examples in the kafka processor?

 

List validators worry me because they allow multiple modes of validation where one will do,
and if the allowable value set can be built easily, then that is preferable. I'm sure there
could be cases where a list validator is necessary but it allows the complexity of separate
validators, which I'm suspect of us needing.

 

> Implement listvalidators
> ------------------------
>
>                 Key: MINIFICPP-985
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-985
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: New Feature
>    Affects Versions: 0.6.0
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Major
>             Fix For: 0.7.0
>
>
> As [~nghiaxlee] pointed out in a change we don't have the functionality to create list
validators (in which case all elements of the input lists should be validated using an encapsulated
validator), so we can't validate multiple choice properties for eg. 
> The change itself is quite easy, although we should keep in mind C2 integration. Because
of this [~phrocker] and [~kdoran] I would like to ask for your feedback on adding this into
agent manifest. Thanks in advance!
> I scoped this for 0.7.0 as the MiNiFi impact would be small, however I can accept rescheduling
it to 0.8.0 in case C2 integration requires more effort and testing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message