Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 8 Sep 2017 16:57:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.13100483.1504794446000.62759.1504889820658@Atlassian.JIRA>
In-Reply-To: <JIRA.13100483.1504794446000@Atlassian.JIRA>
References: <JIRA.13100483.1504794446000@Atlassian.JIRA> <JIRA.13100483.1504794446316@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-4361) Server fails to start during
 recovery upon full disk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Sep 2017 16:57:06 -0000


    [ https://issues.apache.org/jira/browse/NIFI-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158922#comment-16158922 ] 

ASF GitHub Bot commented on NIFI-4361:
--------------------------------------

Github user gresockj commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2133#discussion_r137839524
  
    --- Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java ---
    @@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo
                     subsequentTransactionId = nextPartition.getNextRecoverableTransactionId();
                 } catch (final IOException e) {
                     logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; "
    -                        + "assuming crash and ignoring this transaction",
    +                        + "attempting to get the next recoverable transaction ID",
    --- End diff --
    
    I had a thought that this would be necessary, but I'm not sure what the ending condition would be.  How would you determine that we've run out of recovery files?


> Server fails to start during recovery upon full disk
> ----------------------------------------------------
>
>                 Key: NIFI-4361
>                 URL: https://issues.apache.org/jira/browse/NIFI-4361
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 1.2.0, 1.3.0
>            Reporter: Joseph Gresock
>            Assignee: Joseph Gresock
>             Fix For: 1.4.0
>
>
> Our disk filled up -- we then freed up some space and restarted, but the server failed to start up due to:
> ERROR [main] o.a.nifi.controller.StandardFlowService Failed to load flow from cluster due to: org.apache.nifi.cluster.ConnectionException: Failed to connect node to cluster due to: java.lang.IllegalStateException: Signaled end to recovery, but there are more recovery files for Partition in directory /data/nifi/flowfile_repository/partition-8
> at org.wali.MinimalLockingWriteAheadLog$Partition.endRecovery(MinimalLockingWriteAheadLog.java:1047) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
> at org.wali.MinimalLockingWriteAheadLog.recoverFromEdits(MinimalLockingWriteAheadLog.java:487) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
> at org.wali.MinimalLockingWriteAheadLog.recoverRecords(MinimalLockingWriteAheadLog.java:301) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)