Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Wed, 6 Sep 2017 13:34:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.13100118.1504698909000.39398.1504704840268@Atlassian.JIRA>
In-Reply-To: <JIRA.13100118.1504698909000@Atlassian.JIRA>
References: <JIRA.13100118.1504698909000@Atlassian.JIRA> <JIRA.13100118.1504698909091@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-4355) ExecuteSQL - add query execution
 duration as an attribute
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 06 Sep 2017 13:34:04 -0000


    [ https://issues.apache.org/jira/browse/NIFI-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155335#comment-16155335 ] 

ASF GitHub Bot commented on NIFI-4355:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/2129

    NIFI-4355 - query execution time as attribute of ExecuteSQL

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-4355

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2129
    
----
commit 840011a84a05f0a23075c698eaf297f41cae6b2c
Author: Pierre Villard <pierre.villard.fr@gmail.com>
Date:   2017-09-06T13:28:48Z

    NIFI-4355 - query execution time as attribute of ExecuteSQL

----


> ExecuteSQL - add query execution duration as an attribute
> ---------------------------------------------------------
>
>                 Key: NIFI-4355
>                 URL: https://issues.apache.org/jira/browse/NIFI-4355
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Trivial
>
> It can be interesting to have the query execution time as an attribute after the ExecuteSQL processor for a monitoring perspective. This information is already added in the provenance event emitted by the processor but querying the provenance repo for this specific information could create an unnecessary overhead when millions of events are generated every hour.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)