Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 8 Sep 2017 20:00:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.13099169.1504255058000.64421.1504900800060@Atlassian.JIRA>
In-Reply-To: <JIRA.13099169.1504255058000@Atlassian.JIRA>
References: <JIRA.13099169.1504255058000@Atlassian.JIRA> <JIRA.13099169.1504255058460@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-4341) Display provenance repository
 storage usage in UI
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Sep 2017 20:00:07 -0000


    [ https://issues.apache.org/jira/browse/NIFI-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159196#comment-16159196 ] 

ASF GitHub Bot commented on NIFI-4341:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2119#discussion_r137877545
  
    --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/FileUtils.java ---
    @@ -592,4 +592,41 @@ public static boolean isSame(final File file1, final File file2) throws IOExcept
             return digest.digest();
         }
     
    +    /**
    +     * Returns the capacity for a given path associated to a container name
    +     * @param containerName container name
    +     * @param path path
    +     * @return total space
    +     * @throws IOException in case there is no space
    +     */
    +    public static long getContainerCapacity(final String containerName, final Path path) throws IOException {
    +        if (path == null) {
    --- End diff --
    
    Based on the other comments I've left, it may make sense to remove these checks from the utility method and instead perform the checks from where these methods are invoked. Since in some instances, we have a `Path` already and other instances we have a `File`. Not sure... just offering it as a possibility.


> Display provenance repository storage usage in UI
> -------------------------------------------------
>
>                 Key: NIFI-4341
>                 URL: https://issues.apache.org/jira/browse/NIFI-4341
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>         Attachments: clusterView.png, systemDiagView.png
>
>
> Just like we have storage usage information for flow file repository and content repository, it'd be interesting to display the same information for provenance repository in system diagnostic view and cluster view.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)